user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] inbox: cloneurl: avoid undef to hash table value
Date: Sun, 26 Sep 2021 01:42:29 +0000	[thread overview]
Message-ID: <20210926014229.21296-1-e@80x24.org> (raw)

This saves us some memory for the hash slot in the common case
the `cloneurl' file doesn't exist.
---
 lib/PublicInbox/Inbox.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 3ba92c99..1d5fc708 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -216,11 +216,11 @@ sub description {
 
 sub cloneurl {
 	my ($self) = @_;
-	($self->{cloneurl} //= do {
+	$self->{cloneurl} // do {
 		my $s = try_cat("$self->{inboxdir}/cloneurl");
 		my @urls = split(/\s+/s, $s);
-		scalar(@urls) ? \@urls : undef
-	}) // [];
+		scalar(@urls) ? ($self->{cloneurl} = \@urls) : undef;
+	} // [];
 }
 
 sub base_url {

                 reply	other threads:[~2021-09-26  1:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210926014229.21296-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH] inbox: cloneurl: avoid undef to hash table value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).