user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 2/3] lei: restore old sigmask before daemon exit
Date: Sat, 25 Sep 2021 05:49:44 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

If the event loop fails, we want blocking waitpid (wait4) calls
to be interruptible with SIGTERM via "kill $PID" rather than
SIGKILL.  Though a failing event loop is something we should
 lib/PublicInbox/ | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 9d5a5a46b398..3ff8a347af8b 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -1346,6 +1346,8 @@ sub lazy_start {
 	# $daemon pipe to `lei' closed, main loop begins:
 	eval { PublicInbox::DS->EventLoop };
 	warn "event loop error: $@\n" if $@;
+	# exit() may trigger waitpid via various DESTROY, ensure interruptible
+	PublicInbox::DS::sig_setmask($oldset);
 	exit($exit_code // 0);

  parent reply	other threads:[~2021-09-25  5:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  5:49 [PATCH 0/3] lei: some robustness fixes Eric Wong
2021-09-25  5:49 ` [PATCH 1/3] lei up: show timezone offset with localtime Eric Wong
2021-09-25  5:49 ` Eric Wong [this message]
2021-09-25  5:49 ` [PATCH 3/3] lei2mail: augment_inprogress: guard against closed FDs Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).