From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 202091F8C8 for ; Tue, 21 Sep 2021 20:57:59 +0000 (UTC) Received: by mail-qk1-x736.google.com with SMTP id c7so2150773qka.2 for ; Tue, 21 Sep 2021 13:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=x5+brb53/Xn+uYsjuP/8R1OV7UDe59I0+5Mq1Neo1Mk=; b=KNl+AWeXXaotm+UWR47fSIHyooTJKYhsf9yGBO2E2T21H6xag9XVu+S5VjzvojcE/9 6Y8ufbUAPZMa+9UbLIlrtjFv0m+4nHXGSLFn90S1/8s6VQrg19yJ+oEWHuSZ2F0KhemD VqXKPfViI3xpCEtX+Hiph3sk54ON2sd2/RgQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=x5+brb53/Xn+uYsjuP/8R1OV7UDe59I0+5Mq1Neo1Mk=; b=MqxijQTnG46EfU6aI+Xm+VzImF7PVx8bODYNfE7FgbDnTM+912X/pCPnR8xhAJnXrQ 8Ze5F8Eh6av0Ri+qku5S6J5EXMplF/z3Y8YmfVwPW/iL0JFa1/baM4nS6Yz+fgoILAuS rHZ2ozBmZKDcM0/eo5HfgONkdKTmIgh3mJ4NuMZuducvibS89oFEJ9nAbrPhgi8j0ZIG gEIn3TMBIE0UJiXFFPV2fd0dPtsvcT81j/vBo3BsYXmTeLxAHfxGXpecBVqlOYObgvxl t1tLqZWAgePF3MLodwzGY+R3XD7nkMfcaRsUbJrLYZxtG3QsKgD5GlQ/1CG2uRswwKGZ qXrQ== X-Gm-Message-State: AOAM532Uf9hklWJBP3eUOcFwVq1DSkqLzZXg/PcBPJCW/iH4FFdtwAwf LWbF0Nbm9/RNdevIpbnqbqscuw== X-Google-Smtp-Source: ABdhPJydynUzRMX6IE3EViAmP0z08u33abGGb0OE1f+K1ex8d/M3sWs07+GzB733goNLryPod7tasA== X-Received: by 2002:a37:27d5:: with SMTP id n204mr3746824qkn.31.1632257878017; Tue, 21 Sep 2021 13:57:58 -0700 (PDT) Received: from meerkat.local (bras-base-mtrlpq5031w-grc-32-216-209-220-181.dsl.bell.ca. [216.209.220.181]) by smtp.gmail.com with ESMTPSA id h66sm141815qkc.5.2021.09.21.13.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 13:57:57 -0700 (PDT) Date: Tue, 21 Sep 2021 16:57:56 -0400 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: Holding on to deleted packfiles Message-ID: <20210921205756.2kgyln6kwwbncani@meerkat.local> References: <20210921144754.gulkneuulzo27qbw@meerkat.local> <20210921190653.GA16367@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210921190653.GA16367@dcvr> List-Id: On Tue, Sep 21, 2021 at 07:06:53PM +0000, Eric Wong wrote: > Was this from /all/ (ALL.git using batch-file) or Gcf2? I believe this was from Gcf2, though I can't go back and check, unfortunately. > The old stuff has timers to do periodic cleanup, but the new > stuff is trickier as the cost of a restart is higher... > > It should be alright to wire up the old timers to ALL.git with > (hundreds) of inboxes lore currently has. git 2.33+ should be > better when we get into the thousands; but it's still not > great. Well, it may also not be something that's the responsibility of public-inbox either, e.g. other long-running daemons don't perform such checks. We can just issue a reload after we've done repacking. I was just wondering if perhaps you already did something that would recognize that old pack files have gone away. -K