user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: Holding on to deleted packfiles
Date: Tue, 21 Sep 2021 19:06:53 +0000	[thread overview]
Message-ID: <20210921190653.GA16367@dcvr> (raw)
In-Reply-To: <20210921144754.gulkneuulzo27qbw@meerkat.local>

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> Hello:
> 
> A large git repack job that ran over the weekend revealed a minor problem --
> public-inbox daemon processes will hold on to deleted pack files until they
> are restarted. Is there any way to gracefully recognize and handle this
> condition? It's not quite benign, as this ended up keeping 40GB+ worth of
> inodes from being released.

Was this from /all/ (ALL.git using batch-file) or Gcf2?

The old stuff has timers to do periodic cleanup, but the new
stuff is trickier as the cost of a restart is higher...

It should be alright to wire up the old timers to ALL.git with
(hundreds) of inboxes lore currently has.  git 2.33+ should be
better when we get into the thousands; but it's still not
great.

Gcf2/libgit2 startup time is slow compared to git 2.33+, but
I can write a dumb fstat loop to periodically look for
st_nlink==0...

At some point, I'd like to fix git.git to release packs
(and add alternates dynamically)

  reply	other threads:[~2021-09-21 19:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21 14:47 Konstantin Ryabitsev
2021-09-21 19:06 ` Eric Wong [this message]
2021-09-21 20:57   ` Konstantin Ryabitsev
2021-09-21 21:37     ` Eric Wong
2021-09-22  9:45       ` [PATCH] gcf2 + extsearch: check for unlinked files on Linux Eric Wong
2021-09-22 19:51         ` Eric Wong
2021-09-23  0:46         ` [PATCH 2/1] daemons: revamp periodic cleanup task Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210921190653.GA16367@dcvr \
    --to=e@80x24.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=meta@public-inbox.org \
    --subject='Re: Holding on to deleted packfiles' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).