From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] net_reader: quote URL properly for Tor .onion hint
Date: Sat, 18 Sep 2021 21:09:14 +0000 [thread overview]
Message-ID: <20210918210914.3979-1-e@80x24.org> (raw)
The semicolon in ';AUTH=ANONYMOUS' requires quoting in Bourne shell.
---
lib/PublicInbox/NetReader.pm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index ccfdd261..30b8f810 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -71,19 +71,21 @@ sub onion_hint ($$) {
my ($lei, $uri) = @_;
$uri->host =~ /\.onion\z/i or return "\n";
my $t = $uri->isa('PublicInbox::URIimap') ? 'imap' : 'nntp';
- my $url = uri_section($uri);
+ my $url = PublicInbox::Config::squote_maybe(uri_section($uri));
my $set_cfg = 'lei config';
if (!$lei) { # public-inbox-watch
- my $f = $ENV{PI_CONFIG} || '~/.public-inbox/config';
+ my $f = PublicInbox::Config::squote_maybe(
+ $ENV{PI_CONFIG} || '~/.public-inbox/config');
$set_cfg = "git config -f $f";
}
+ my $dq = substr($url, 0, 1) eq "'" ? '"' : '';
<<EOM
Assuming you have Tor configured and running locally on port 9050,
try configuring a socks5h:// proxy:
url=$url
- $set_cfg $t.\$url.proxy socks5h://127.0.0.1:9050
+ $set_cfg $t.$dq\$url$dq.proxy socks5h://127.0.0.1:9050
...before retrying your current command
EOM
reply other threads:[~2021-09-18 21:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210918210914.3979-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).