From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8205A1F9F3 for ; Sun, 12 Sep 2021 08:42:20 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/3] test_common: only print $@ for Gcf2 failure Date: Sun, 12 Sep 2021 08:42:19 +0000 Message-Id: <20210912084219.11609-4-e@80x24.org> In-Reply-To: <20210912084219.11609-1-e@80x24.org> References: <20210912084219.11609-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Other missing dependencies are more straightforward, but Gcf2 requires a combination of libgit2-dev, pkg-config, Inline::C, and proper setup. This significantly reduces noise in tests with a minimal set of dependencies installed. --- lib/PublicInbox/TestCommon.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm index d28b32b0..628beaf1 100644 --- a/lib/PublicInbox/TestCommon.pm +++ b/lib/PublicInbox/TestCommon.pm @@ -144,7 +144,7 @@ sub require_mods { eval "require $mod"; } if ($@) { - diag "require $mod: $@"; + diag "require $mod: $@" if $mod =~ /Gcf2/; push @need, $mod; } elsif ($mod eq 'IO::Socket::SSL' && # old versions of IO::Socket::SSL aren't supported