From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] t/lei-auto-watch: improve test reliability
Date: Thu, 2 Sep 2021 22:36:46 +0000 [thread overview]
Message-ID: <20210902223647.6515-2-e@80x24.org> (raw)
In-Reply-To: <20210902223647.6515-1-e@80x24.org>
On slower systems, even a 100ms delay may not be enough;
so loop and retry in hopes of an early exit for faster
systems.
---
t/lei-auto-watch.t | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/t/lei-auto-watch.t b/t/lei-auto-watch.t
index 146402a6..3b0c1b10 100644
--- a/t/lei-auto-watch.t
+++ b/t/lei-auto-watch.t
@@ -4,9 +4,8 @@
use strict; use v5.10.1; use PublicInbox::TestCommon;
use File::Basename qw(basename);
my ($ro_home, $cfg_path) = setup_public_inboxes;
-my $tick = 2.1;
-my $have_fast_inotify = eval { require Linux::Inotify2; $tick = 0.1 } ||
- eval { require IO::KQueue; $tick = 0.5 };
+my $have_fast_inotify = eval { require Linux::Inotify2 } ||
+ eval { require IO::KQueue };
$have_fast_inotify or
diag("$0 IO::KQueue or Linux::Inotify2 missing, test will be slow");
@@ -31,9 +30,13 @@ test_lei(sub {
lei_ok qw(add-watch), $x;
my $dst = $x[0] . 'S';
rename($x[0], $dst) or xbail "rename($x[0], $dst): $!";
- tick($tick); # wait for inotify or kevent
+ my $ys = "$y[0]S";
+ for (0..50) {
+ last if -f $ys;
+ tick; # wait for inotify or kevent
+ }
my @y2 = glob("$y/*/*");
- is_deeply(\@y2, [ "$y[0]S" ], "`seen' kw propagated to `y' dir");
+ is_deeply(\@y2, [ $ys ], "`seen' kw propagated to `y' dir");
lei_ok qw(note-event done);
lei_ok qw(inspect), "blob:$oid";
$ins = json_utf8->decode($lei_out);
next prev parent reply other threads:[~2021-09-02 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 22:36 [PATCH 0/2] test reliability fixes Eric Wong
2021-09-02 22:36 ` Eric Wong [this message]
2021-09-02 22:36 ` [PATCH 2/2] tests: "make check-run" favors reliability over speed Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902223647.6515-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).