user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: [PATCH 0/2] wwwlisting shows /all/
Date: Fri, 27 Aug 2021 12:08:43 +0000	[thread overview]
Message-ID: <20210827120845.29682-1-e@80x24.org> (raw)
In-Reply-To: <20210826170114.r4j4cpf6hzrhzktt@nitro.local>

Konstantin Ryabitsev wrote:
> Hello:
> 
> I switched the configuration to return wwwlisting as toplevel view (instead of
> redirecting / to /all/), but there's some discontent, because the easy
> interface to "search everything" is gone and unless someone knows about /all/,
> they wouldn't find out about it from the wwwlisting view.
> 
> How about, if there is an extindex "all" defined, the wwwlisting adds an extra
> search box:
> 
> [_________________] [search all] help
> 
> * 2021-08-26 16:54 - https://x-lore.kernel.org/all/
>   All of lore.kernel.org
> 
> ------------------------------------------------------
> 
> [_________________] [locate inbox]
> 
> * 2021-08-26 16:54 - https://x-lore.kernel.org/lkml/
>   [description]
>   [infourl]

I think that's too much vertical whitespace at the top of the
page, and multiple <form>s or <input> boxes at the top can get
confusing.

Just making /all/ show up at the top like a normal inbox (and
letting the admin decide on description) seems sufficient.  If
users can get to /all/ then they can search /all/ as normal.

I tried moving the <input>s next to infourl, but mixing <form>
and <pre> introduces a lot of vertical whitespace.


I also tried adding radio button (or drop-down):

	[_________________] [*] inboxes [ ] /all/   [search]

But extra <form> elements always confuse me whenever I encounter
them in any browser, so I decided to just leave things alone.

Eric Wong (2):
  www_listing: show ->ALL at top of HTML listing
  www_listing: fix odd "locate inbox" cases

 lib/PublicInbox/WwwListing.pm | 50 +++++++++++++++++++++++------------
 t/extindex-psgi.t             | 12 +++++++++
 2 files changed, 45 insertions(+), 17 deletions(-)

  reply	other threads:[~2021-08-27 12:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 17:01 Add a way to search all from wwwlisting Konstantin Ryabitsev
2021-08-27 12:08 ` Eric Wong [this message]
2021-08-27 12:08   ` [PATCH 1/2] www_listing: show ->ALL at top of HTML listing Eric Wong
2021-08-27 12:08   ` [PATCH 2/2] www_listing: fix odd "locate inbox" cases Eric Wong
2021-08-27 13:03   ` [PATCH 0/2] wwwlisting shows /all/ Konstantin Ryabitsev
2021-08-27 14:33     ` Konstantin Ryabitsev
2021-08-27 22:03       ` [PATCH] www: avoid potential auto-vivification on ibx->{url} Eric Wong
2021-08-28 18:00         ` Konstantin Ryabitsev
2021-08-27 21:15     ` [PATCH 0/2] wwwlisting shows /all/ Eric Wong
2021-09-26  1:30   ` [PATCH] www_listing: support /all/ search as a 302 redirect Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210827120845.29682-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).