* [PATCH] li2wrap: avoid double-close on Linux::Inotify2 <2.3
@ 2021-08-06 0:29 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-08-06 0:29 UTC (permalink / raw)
To: meta
LI2Wrap was not working as expected due to the missing bless
to override ->DESTROY. This bug showed up in an message check in
t/lei-q-remote-import.t
Fixes: 7fc6e30aeab9925b ("lei: close inotify FD in forked child")
---
lib/PublicInbox/LI2Wrap.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/LI2Wrap.pm b/lib/PublicInbox/LI2Wrap.pm
index 61cf4bee..204850a6 100644
--- a/lib/PublicInbox/LI2Wrap.pm
+++ b/lib/PublicInbox/LI2Wrap.pm
@@ -12,6 +12,7 @@ sub wrapclose {
my ($inot) = @_;
my $fd = $inot->fileno;
open my $fh, '<&=', $fd or die "open <&= $fd $!";
+ bless $inot, __PACKAGE__;
}
sub DESTROY {} # no-op
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-08-06 0:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 0:29 [PATCH] li2wrap: avoid double-close on Linux::Inotify2 <2.3 Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).