From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: Restarting daemons on config file change
Date: Tue, 20 Jul 2021 20:34:33 +0000 [thread overview]
Message-ID: <20210720203433.GA28287@dcvr> (raw)
In-Reply-To: <20210720170019.p5d23tjb4v2mrekn@nitro.local>
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Mon, Jul 19, 2021 at 08:49:35PM +0000, Eric Wong wrote:
> > > The best I can think of is a systemd watcher service that automatically
> > > restarts the daemons when the config file is modified, but I wanted to check
> > > here first to see if perhaps I'm missing something simpler.
> >
> > Yes, a systemd.path unit might be the way to go. A patch for
> > examples/ would be appreciated if you go down that route :>
>
> Okay, let me see what I can come up with. Looks like the best course of action
> is to:
>
> 1. use a global blocking lock
> 2. copy the config file to a new location
> 3. make the necessary changes to the temporary config file
> 4. move the temp config file to overwrite the current config
> 5. release the lock
public-inbox-init already does all of that. It doesn't set
all possible keys, yet (e.g. infourl, maybe some others).
> This would make sure that there is are no races and that all changes show up
> at once and don't repeatedly trigger the path watcher.
next prev parent reply other threads:[~2021-07-20 20:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 20:03 Restarting daemons on config file change Konstantin Ryabitsev
2021-07-19 20:49 ` Eric Wong
2021-07-20 8:58 ` [PATCH] httpd: fix SIGHUP by invalidating cache on reload Eric Wong
2021-07-20 17:00 ` Restarting daemons on config file change Konstantin Ryabitsev
2021-07-20 20:34 ` Eric Wong [this message]
2021-07-20 20:49 ` Konstantin Ryabitsev
2021-07-20 21:07 ` Eric Wong
2021-07-20 21:18 ` Konstantin Ryabitsev
2021-07-21 14:05 ` [PATCH 1/2] extsearch: support publicinbox.*.boost parameter Eric Wong
2021-07-21 14:05 ` [PATCH 2/2] init: allow arbitrary key-values via -c KEY=VALUE Eric Wong
2021-07-25 10:40 ` [PATCH 3/2] init: support git <2.30 for "-c KEY=VALUE" args Eric Wong
2021-07-21 15:32 ` [PATCH 0/2] things to make mirroring easier Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720203433.GA28287@dcvr \
--to=e@80x24.org \
--cc=konstantin@linuxfoundation.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).