From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/2] lei Maildir inotify/kevent support
Date: Mon, 19 Jul 2021 08:59:33 +0000 [thread overview]
Message-ID: <20210719085935.1986-1-e@80x24.org> (raw)
One of the most important features of lei that drove the
decision towards its daemonic architecture.
My brain still has some wires loose or crossed :<
So I've had a very tough time mapping out the internal design
for this that could deal with rename() storms and reduce the
need to handle IN_Q_OVERFLOW conditions. Eventually,
introducing a new concept in the form of LeiNoteEvent helped my
crippled brain make the necessary connections and cobble
together something that seems halfway working.
LeiNoteEvent represents a significant conceptual shift in lei
internals. Having long-lived workers is closer to my original
vision of how lei internals would've been. That old model had
some major weaknesses, however:
1) error handling/reporting back to the CLI required FD passing
(and large-scale FD passing got confusing pretty quick)
2) excessive FD passing overflowed default kernel buffers
and made parallelism difficult for unprivileged users
Since there's no CLI to report errors to with internal
notifications, we don't have FDs to pass. Of course, that
means we can lose errors right now, but it's probably not
a big deal for (mostly) innocuous keyword changes.
Eric Wong (2):
config: s/_one_val/get_1/ for public use
lei: start implementing inotify Maildir support
MANIFEST | 6 ++
lib/PublicInbox/Config.pm | 6 +-
lib/PublicInbox/DirIdle.pm | 17 +++++
lib/PublicInbox/LEI.pm | 116 ++++++++++++++++++++++++++---
lib/PublicInbox/LeiAddWatch.pm | 41 ++++++++++
lib/PublicInbox/LeiInput.pm | 1 +
lib/PublicInbox/LeiLsWatch.pm | 15 ++++
lib/PublicInbox/LeiNoteEvent.pm | 124 +++++++++++++++++++++++++++++++
lib/PublicInbox/LeiSearch.pm | 2 +-
lib/PublicInbox/LeiSelfSocket.pm | 45 +++++++++++
lib/PublicInbox/LeiWatch.pm | 13 ++++
t/lei-watch.t | 49 ++++++++++++
12 files changed, 419 insertions(+), 16 deletions(-)
create mode 100644 lib/PublicInbox/LeiAddWatch.pm
create mode 100644 lib/PublicInbox/LeiLsWatch.pm
create mode 100644 lib/PublicInbox/LeiNoteEvent.pm
create mode 100644 lib/PublicInbox/LeiSelfSocket.pm
create mode 100644 lib/PublicInbox/LeiWatch.pm
create mode 100644 t/lei-watch.t
next reply other threads:[~2021-07-19 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 8:59 Eric Wong [this message]
2021-07-19 8:59 ` [PATCH 1/2] config: s/_one_val/get_1/ for public use Eric Wong
2021-07-19 8:59 ` [PATCH 2/2] lei: start implementing inotify Maildir support Eric Wong
2021-07-21 14:07 ` [PATCH 3/2] lei: auto-refresh watches in config, cancel missing Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719085935.1986-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).