From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B2C4F1F8C6 for ; Wed, 7 Jul 2021 23:24:55 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] extsearchidx: ignore Eml warnings across the board Date: Wed, 7 Jul 2021 23:24:55 +0000 Message-Id: <20210707232455.27204-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: There's nothing we can do about misformatted emails and headers we get from untrusted sources. They're too noisy and those messages already exist in public-inboxes, anyways, so just keep things quiet so we can spot real problems more easily. --- lib/PublicInbox/ExtSearchIdx.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 495579a2..a421e16b 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -891,10 +891,6 @@ SELECT DISTINCT(mid),id FROM msgid WHERE id IN ORDER BY id EOS $iter->execute($min_id); - local $SIG{__WARN__} = sub { - return if PublicInbox::Eml::warn_ignore(@_); - warn @_; - }; while (my ($mid, $id) = $iter->fetchrow_array) { last if $sync->{quit}; $self->{current_info} = "dedupe $mid"; @@ -942,6 +938,7 @@ sub eidx_sync { # main entry point my $warn_cb = $SIG{__WARN__} || \&CORE::warn; local $self->{current_info} = ''; local $SIG{__WARN__} = sub { + return if PublicInbox::Eml::warn_ignore(@_); $warn_cb->($self->{current_info}, ': ', @_); }; $self->idx_init($opt); # acquire lock via V2Writable::_idx_init @@ -1238,7 +1235,10 @@ sub eidx_watch { # public-inbox-extindex --watch main loop my $oldset = PublicInbox::DS::block_signals(); local $self->{current_info} = ''; my $cb = $SIG{__WARN__} || \&CORE::warn; - local $SIG{__WARN__} = sub { $cb->($self->{current_info}, ': ', @_) }; + local $SIG{__WARN__} = sub { + return if PublicInbox::Eml::warn_ignore(@_); + $cb->($self->{current_info}, ': ', @_); + }; my $sig = { HUP => sub { eidx_reload($self, $idler) }, USR1 => sub { eidx_resync_start($self) },