user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/3] extindex: --gc: avoid SQLite lock conflict on shard cleanup
Date: Tue,  6 Jul 2021 12:42:03 +0000	[thread overview]
Message-ID: <20210706124203.17745-4-e@80x24.org> (raw)
In-Reply-To: <20210706124203.17745-1-e@80x24.org>

Xapian shard cleanup only requires read-only access to
over.sqlite3, so avoid opening it with read-write access since
create_tables will hit lock conflicts on "INSERT OR IGNORE"
statements.
---
 lib/PublicInbox/SearchIdxShard.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm
index 1598faeb..8635f585 100644
--- a/lib/PublicInbox/SearchIdxShard.pm
+++ b/lib/PublicInbox/SearchIdxShard.pm
@@ -78,8 +78,9 @@ sub shard_close {
 sub shard_over_check {
 	my ($self, $over) = @_;
 	if ($self->{-ipc_req} && $over->{dbh}) {
-		# can't send DB handles over IPC
-		$over = ref($over)->new($over->{dbh}->sqlite_db_filename);
+		# can't send DB handles over IPC, and use read-only to avoid
+		# create_tables lock conflict:
+		$over = PublicInbox::Over->new($over->{dbh}->sqlite_db_filename)
 	}
 	$self->ipc_do('over_check', $over);
 }

      parent reply	other threads:[~2021-07-06 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 12:42 [PATCH 0/3] extindex: dedupe support, + gc fix Eric Wong
2021-07-06 12:42 ` [PATCH 1/3] eml: relax warn_ignore regexps for current Email::Address::XS Eric Wong
2021-07-06 12:42 ` [PATCH 2/3] extindex: implement --dedupe to fix old extindices Eric Wong
2021-07-06 12:42 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706124203.17745-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).