From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B182B1F8C6 for ; Tue, 22 Jun 2021 10:04:36 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] lei: use open() perlop for -C (chdir) Date: Tue, 22 Jun 2021 10:04:36 +0000 Message-Id: <20210622100436.24072-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This is for consistency with the open() at initial accept, in case we hit a code path which expects Perl directory handles rather than "file handles". Both work with the chdir() perlop (fchdir(2), in our case). --- lib/PublicInbox/LEI.pm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 546fa773..cffe4dce 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -762,11 +762,7 @@ sub dispatch { next if $d eq ''; # same as git(1) chdir $d or return fail($self, "cd $d: $!"); } - if (delete $self->{3}) { # update cwd for rel2abs - opendir my $dh, '.' or - return fail($self, "opendir . $!"); - $self->{3} = $dh; - } + open $self->{3}, '.' or return fail($self, "open . $!"); } $cb->($self, @argv); } elsif (grep(/\A-/, $cmd, @argv)) { # --help or -h only