From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D88A21F5AE for ; Tue, 8 Jun 2021 23:56:13 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] lei pmdir: fix nproc for <= 4 CPUs Date: Tue, 8 Jun 2021 23:56:13 +0000 Message-Id: <20210608235613.15577-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: I forgot my FreeBSD VM has 8 cores, actually, and tweaked the nproc detection on that machine before finalizing commit 10b523eb017162240b1ac3647f8dcbbf2be348a7 ("lei import: speed up repeated Maildir imports") Fixes: 10b523eb01716224 ("lei import: speed up repeated Maildir imports") --- lib/PublicInbox/LeiPmdir.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/LeiPmdir.pm b/lib/PublicInbox/LeiPmdir.pm index 5efb012e..b71efe70 100644 --- a/lib/PublicInbox/LeiPmdir.pm +++ b/lib/PublicInbox/LeiPmdir.pm @@ -13,14 +13,14 @@ use parent qw(PublicInbox::IPC); sub new { my ($cls, $lei, $ipt) = @_; my $self = bless { -wq_ident => 'lei Maildir worker' }, $cls; - my $jobs = $lei->{opt}->{jobs}; + my $jobs = $lei->{opt}->{jobs} // ''; $jobs =~ /\A[0-9]+,([0-9]+)\z/ and $jobs = $1; - my $nproc = $jobs // do { - # untested with >=4 CPUs, though I suspect I/O latency + my $nproc = $jobs || do { + # barely tested with >=4 CPUs, though I suspect I/O latency # of SATA SSD storage will make >=4 processes unnecessary, # here. NVMe users may wish to use '-j' my $n = $self->detect_nproc; - $n = 4 if $n > 4; + $n = $n > 4 ? 4 : $n; }; my ($op_c, $ops) = $lei->workers_start($self, $nproc, undef, { ipt => $ipt }); # LeiInput subclass