user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] lei_mail_sync: more debug info for uncommitted txn
@ 2021-06-01 19:14 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-06-01 19:14 UTC (permalink / raw)
  To: meta

I'm not actually sure if I hit an uncommitted transaction just
now, it doesn't seem like it.
---
 lib/PublicInbox/LeiMailSync.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm
index 36cd564c..22ee1109 100644
--- a/lib/PublicInbox/LeiMailSync.pm
+++ b/lib/PublicInbox/LeiMailSync.pm
@@ -392,10 +392,11 @@ sub imap_oid {
 # warnings, not sure what...
 sub DESTROY {
 	my ($self) = @_;
-	my $dbh = $self->{dbh} or return;
+	my $dbh = delete($self->{dbh}) or return;
 	return if $dbh->{ReadOnly};
 	use Carp;
-	warn "BUG $$ $0 $self {dbh} UNCOMMITTED ", Carp::longmess();
+	undef $dbh;
+	warn "BUG $$ $0 $self {dbh} OPEN ppid=".getppid.' '.Carp::longmess();
 }
 
 1;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-01 19:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 19:14 [PATCH] lei_mail_sync: more debug info for uncommitted txn Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).