From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 97ACA1FA13 for ; Wed, 28 Apr 2021 07:52:05 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 03/11] view_diff: minor coding style fixes Date: Wed, 28 Apr 2021 07:51:57 +0000 Message-Id: <20210428075205.19440-4-e@80x24.org> In-Reply-To: <20210428075205.19440-1-e@80x24.org> References: <20210428075205.19440-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Prefer "use v5.10", s/base/parent/, rely on "perl -w" for warnings. We also pass a regexp to the split perlop rather than literal SV, since split() will compile a new RE every time. --- lib/PublicInbox/ViewDiff.pm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index e9a7bf69..d2c5fabe 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -7,10 +7,9 @@ # (or reconstruct) blobs. package PublicInbox::ViewDiff; -use 5.010_001; use strict; -use warnings; -use base qw(Exporter); +use v5.10.1; +use parent qw(Exporter); our @EXPORT_OK = qw(flush_diff); use URI::Escape qw(uri_escape_utf8); use PublicInbox::Hval qw(ascii_html to_attr); @@ -122,8 +121,8 @@ sub diff_header ($$$) { my $dctx = { spfx => $spfx }; # get rid of leading "a/" or "b/" (or whatever --{src,dst}-prefix are) - $pa = (split('/', git_unquote($pa), 2))[1] if $pa ne '/dev/null'; - $pb = (split('/', git_unquote($pb), 2))[1] if $pb ne '/dev/null'; + $pa = (split(m'/', git_unquote($pa), 2))[1] if $pa ne '/dev/null'; + $pb = (split(m'/', git_unquote($pb), 2))[1] if $pb ne '/dev/null'; if ($pa eq $pb && $pb ne '/dev/null') { $dctx->{Q} = "?b=".uri_escape_utf8($pb, UNSAFE); } else {