user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] lei blob: cleanup solver tmpdir on failure
@ 2021-03-29 17:47 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-03-29 17:47 UTC (permalink / raw)
  To: meta

$lei->fail sends SIGTERM which prevents the File::Temp::Dir in
$solver->{tmp} from being cleaned up, so use $lei->child_error
instead.
---
 lib/PublicInbox/LeiBlob.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/LeiBlob.pm b/lib/PublicInbox/LeiBlob.pm
index 91098a90..6195b368 100644
--- a/lib/PublicInbox/LeiBlob.pm
+++ b/lib/PublicInbox/LeiBlob.pm
@@ -39,7 +39,7 @@ sub solver_user_cb { # called by solver when done
 	my $lei = $self->{lei};
 	my $log_buf = delete $lei->{'log_buf'};
 	$$log_buf =~ s/^/# /sgm;
-	ref($res) eq 'ARRAY' or return $lei->fail($$log_buf);
+	ref($res) eq 'ARRAY' or return $lei->child_error(1 << 8, $$log_buf);
 	$lei->qerr($$log_buf);
 	my ($git, $oid, $type, $size, $di) = @$res;
 	my $gd = $git->{git_dir};

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-29 17:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 17:47 [PATCH] lei blob: cleanup solver tmpdir on failure Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).