From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 05/12] lei blob: fail early if no git dirs Date: Sun, 28 Mar 2021 09:01:17 +0000 [thread overview] Message-ID: <20210328090124.3541-6-e@80x24.org> (raw) In-Reply-To: <20210328090124.3541-1-e@80x24.org> This avoids triggering a "BUG:" message in the solver code. --- lib/PublicInbox/LeiBlob.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/LeiBlob.pm b/lib/PublicInbox/LeiBlob.pm index 4bd86253..f44d8af1 100644 --- a/lib/PublicInbox/LeiBlob.pm +++ b/lib/PublicInbox/LeiBlob.pm @@ -103,6 +103,7 @@ sub lei_blob { my $cgd = get_git_dir('.'); unshift(@$git_dirs, $cgd) if defined $cgd; } + return $lei->fail('no --git-dir to try') unless @$git_dirs; my $lxs = $lei->lxs_prepare or return; require PublicInbox::SolverGit; my $self = bless { lxs => $lxs, oid_b => $blob }, __PACKAGE__;
next prev parent reply other threads:[~2021-03-28 9:01 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-28 9:01 [PATCH 00/12] lei blob and some yak-shaving Eric Wong 2021-03-28 9:01 ` [PATCH 01/12] lei: simplify PktOp callers Eric Wong 2021-03-28 9:01 ` [PATCH 02/12] lei init: split out into separate file Eric Wong 2021-03-28 9:01 ` [PATCH 03/12] lei blob: dclose if already failed Eric Wong 2021-03-28 9:01 ` [PATCH 04/12] lei blob: support --no-mail switch Eric Wong 2021-03-28 9:01 ` Eric Wong [this message] 2021-03-28 9:01 ` [PATCH 06/12] lei blob: some extra tests Eric Wong 2021-03-28 9:01 ` [PATCH 07/12] lei help: show "NAME=VALUE" properly for -c Eric Wong 2021-03-28 9:01 ` [PATCH 08/12] lei blob: flesh out help text Eric Wong 2021-03-28 9:01 ` [PATCH 09/12] t/lei_store: ensure LeiSearch responds to ->isrch Eric Wong 2021-03-28 9:01 ` [PATCH 10/12] lei blob: add remote external support Eric Wong 2021-03-28 9:01 ` [PATCH 11/12] lei: drop coderepo placeholders, submodule TODO Eric Wong 2021-03-28 9:31 ` Eric Wong 2021-03-28 9:01 ` [PATCH 12/12] treewide: shorten temporary filename Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210328090124.3541-6-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 05/12] lei blob: fail early if no git dirs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).