From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 61BB61FA00 for ; Sun, 28 Mar 2021 09:01:25 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 03/12] lei blob: dclose if already failed Date: Sun, 28 Mar 2021 09:01:15 +0000 Message-Id: <20210328090124.3541-4-e@80x24.org> In-Reply-To: <20210328090124.3541-1-e@80x24.org> References: <20210328090124.3541-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We must close the socket to trigger pager exit if blob reconstruction fails. Not sure how to test this in the test suite... --- lib/PublicInbox/LeiBlob.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiBlob.pm b/lib/PublicInbox/LeiBlob.pm index 97747220..9b4c4f30 100644 --- a/lib/PublicInbox/LeiBlob.pm +++ b/lib/PublicInbox/LeiBlob.pm @@ -19,7 +19,7 @@ sub sol_done_wait { # dwaitpid callback sub sol_done { # EOF callback for main daemon my ($lei) = @_; - my $sol = delete $lei->{sol} or return; + my $sol = delete $lei->{sol} // return $lei->dclose; # already failed $sol->wq_wait_old(\&sol_done_wait, $lei); }