user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: "Σταύρος Ντέντος" <stdedos@gmail.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH v1] git-send-email-reply: Append subject
Date: Fri, 26 Mar 2021 21:35:17 +0000	[thread overview]
Message-ID: <20210326213517.GA5730@dcvr> (raw)
In-Reply-To: <CAHMHMxVS4tVvUYvWUmk8L8oqPPxtYW-MF_57Vwuzug-asWQiQg@mail.gmail.com>

Σταύρος Ντέντος <stdedos@gmail.com> wrote:
> On Fri, 26 Mar 2021 at 21:36, Eric Wong <e@80x24.org> wrote:
> > Stavros Ntentos <stdedos@gmail.com> wrote:
> > > Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
> >
> > Unlike the git.git project, we don't require Signed-off-by.
> > Furthermore, publicizing "noreply" addresses doesn't seem
> > worthwhile since they're not usable email addresses.
> 
> Forces of habit:
> * git.git requires it, and
> * github masks the e-mail addresses (from weird groupies), and tracks
> contributions.

Fair enough, pushed as 90ca1ac28edb2e8a64c30bb4be723643c646df89 with
t/reply.t adjustments:

  https://public-inbox.org/meta/90ca1ac28edb2e8a64c30bb4be723643c646df89/s/

Also, please don't send HTML email.  It wastes storage, bandwidth,
and CPU cycles (spam filtering) for everybody involved.

> LGTM; I am anyway not accustomed to perl, and neither do I have a testing
> server.
> Hopefully, there is a staging environment (or an easy-to-docker-setup one?)
> that this can be POCed.

I try to stick to widely-packaged dependencies to avoid the need
for things like Docker (which I've never used).  It should be
reasonably easy-to-install on most GNU/Linux and *BSD distros;
do you use anything exotic that's not covered in INSTALL and
HACKING?

	https://public-inbox.org/INSTALL
	https://public-inbox.org/HACKING

> Changes are anyway small enough, so I considered it safe to do it so.

Yes, already deployed to the server that runs public-inbox.org/meta
(I do development on that server :x)

Thanks.

  parent reply	other threads:[~2021-03-26 21:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 16:31 Stavros Ntentos
2021-03-26 19:36 ` Eric Wong
     [not found]   ` <CAHMHMxVS4tVvUYvWUmk8L8oqPPxtYW-MF_57Vwuzug-asWQiQg@mail.gmail.com>
2021-03-26 21:35     ` Eric Wong [this message]
2021-03-27  8:39       ` Stavros Ntentos
2021-03-27  9:54         ` Eric Wong
2021-03-27 14:01           ` Σταύρος Ντέντος
2021-03-27 19:32             ` Eric Wong
2021-03-28 16:00               ` Σταύρος Ντέντος
2021-03-28 22:58                 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326213517.GA5730@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --cc=stdedos@gmail.com \
    --subject='Re: [PATCH v1] git-send-email-reply: Append subject' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).