From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/9] lei: drop circular reference in lei_store process
Date: Wed, 24 Mar 2021 14:23:29 +0500 [thread overview]
Message-ID: <20210324092335.12345-4-e@80x24.org> (raw)
In-Reply-To: <20210324092335.12345-1-e@80x24.org>
I'm not sure if this was causing real problems, but it's sure ugly.
---
lib/PublicInbox/LEI.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index 8cbaac01..ee991f80 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -458,6 +458,9 @@ sub _lei_atfork_child {
unless ($self->{oneshot}) {
close($_) for @io;
}
+ if (my $cfg = $self->{cfg}) {
+ delete $cfg->{-lei_store};
+ }
} else { # worker, Net::NNTP (Net::Cmd) uses STDERR directly
open STDERR, '+>&='.fileno($self->{2}) or warn "open $!";
delete $self->{0};
next prev parent reply other threads:[~2021-03-24 9:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 9:23 [PATCH 0/9] lei: various corner case leak fixes Eric Wong
2021-03-24 9:23 ` [PATCH 1/9] ds: improve DS->Reset fork-safety Eric Wong
2021-03-24 23:01 ` [SQUASH] " Eric Wong
2021-03-24 9:23 ` [PATCH 2/9] mbox_lock: dotlock: chdir for relative lock paths Eric Wong
2021-03-24 9:23 ` Eric Wong [this message]
2021-03-24 9:23 ` [PATCH 4/9] lei: update {3} after -C chdirs Eric Wong
2021-03-24 9:23 ` [PATCH 5/9] lei: clean up pkt_op consumer on exception, too Eric Wong
2021-03-24 9:23 ` [PATCH 6/9] lei_store: give process a better name Eric Wong
2021-03-24 9:23 ` [PATCH 7/9] v2writable: cleanup SQLite handles on --xapian-only Eric Wong
2021-03-24 9:23 ` [PATCH 8/9] lei_mirror: fix circular reference Eric Wong
2021-03-24 9:23 ` [PATCH 9/9] lei-daemon: do not leak FDs on bogus requests Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324092335.12345-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
--subject='Re: [PATCH 3/9] lei: drop circular reference in lei_store process' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).