From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 2/2] config: ignore extindex entries with newlines in paths Date: Fri, 19 Mar 2021 10:35:57 -0200 [thread overview] Message-ID: <20210319123557.19068-3-e@80x24.org> (raw) In-Reply-To: <20210319123557.19068-1-e@80x24.org> git 2.11 and earlier could not handle git directories with newlines in them, nor does libgit2 support them. Followup-to: d87dd0e679587043 ("config: reject `\n' in `inboxdir'") --- lib/PublicInbox/Config.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index 1037c884..770d9256 100644 --- a/lib/PublicInbox/Config.pm +++ b/lib/PublicInbox/Config.pm @@ -514,6 +514,10 @@ sub _fill_ei ($$) { my $pfx = "extindex.$name"; my $d = $self->{"$pfx.topdir"} // return; -d $d or return; + if (index($d, "\n") >= 0) { + warn "E: `$d' must not contain `\\n'\n"; + return; + } my $es = PublicInbox::ExtSearch->new($d); for my $k (qw(indexlevel indexsequentialshard)) { my $v = _one_val($self, $pfx, $k) // next;
prev parent reply other threads:[~2021-03-19 12:35 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-19 12:35 [PATCH 0/2] newline rejection for new stuff Eric Wong 2021-03-19 12:35 ` [PATCH 1/2] lei: disallow "\n" in local externals paths Eric Wong 2021-03-19 12:35 ` Eric Wong [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210319123557.19068-3-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 2/2] config: ignore extindex entries with newlines in paths' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).