From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 27CBA1FD84 for ; Mon, 15 Mar 2021 11:58:34 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 35/35] t/*: disable fsync on tests were create_inbox isn't worth it Date: Mon, 15 Mar 2021 12:58:26 +0100 Message-Id: <20210315115826.17591-36-e@80x24.org> In-Reply-To: <20210315115826.17591-1-e@80x24.org> References: <20210315115826.17591-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Using create_inbox doesn't seem worth the trouble, here, at the moment, but disabling fsync(2) gives a noticeable speedup on my system even with an SSD. --- t/extsearch.t | 2 ++ t/purge.t | 1 + t/replace.t | 1 + t/v1reindex.t | 1 + t/v2-add-remove-add.t | 1 + t/v2mirror.t | 1 + t/v2reindex.t | 1 + t/v2writable.t | 1 + t/watch_filter_rubylang.t | 2 ++ t/watch_maildir_v2.t | 1 + 10 files changed, 12 insertions(+) diff --git a/t/extsearch.t b/t/extsearch.t index d199fc7b..ae889ac6 100644 --- a/t/extsearch.t +++ b/t/extsearch.t @@ -236,6 +236,7 @@ if ('inject w/o indexing') { if ('reindex catches missed messages') { my $v2ibx = $cfg->lookup_name('v2test'); + $v2ibx->{-no_fsync} = 1; my $im = PublicInbox::InboxWritable->new($v2ibx)->importer(0); my $cmt_a = $v2ibx->mm->last_commit_xap($schema_version, 0); my $eml = eml_load('t/data/0001.patch'); @@ -296,6 +297,7 @@ if ('reindex catches missed messages') { if ('reindex catches content bifurcation') { use PublicInbox::MID qw(mids); my $v2ibx = $cfg->lookup_name('v2test'); + $v2ibx->{-no_fsync} = 1; my $im = PublicInbox::InboxWritable->new($v2ibx)->importer(0); my $eml = eml_load('t/data/message_embed.eml'); my $cmt_a = $v2ibx->mm->last_commit_xap($schema_version, 0); diff --git a/t/purge.t b/t/purge.t index f4281c13..a33cd329 100644 --- a/t/purge.t +++ b/t/purge.t @@ -16,6 +16,7 @@ my $ibx = PublicInbox::Inbox->new({ inboxdir => $inboxdir, name => 'test-v2purge', version => 2, + -no_fsync => 1, -primary_address => 'test@example.com', indexlevel => 'basic', }); diff --git a/t/replace.t b/t/replace.t index 51bdb964..626cbe9b 100644 --- a/t/replace.t +++ b/t/replace.t @@ -20,6 +20,7 @@ sub test_replace ($$$) { inboxdir => "$tmpdir/testbox", name => $this, version => $v, + -no_fsync => 1, -primary_address => 'test@example.com', indexlevel => $level, }); diff --git a/t/v1reindex.t b/t/v1reindex.t index 36cefda5..f593b323 100644 --- a/t/v1reindex.t +++ b/t/v1reindex.t @@ -18,6 +18,7 @@ my $ibx_config = { name => 'test-v1reindex', -primary_address => 'test@example.com', indexlevel => 'full', + -no_fsync => 1, }; my $mime = PublicInbox::Eml->new(<<'EOF'); From: a@example.com diff --git a/t/v2-add-remove-add.t b/t/v2-add-remove-add.t index b325e521..579cdcb6 100644 --- a/t/v2-add-remove-add.t +++ b/t/v2-add-remove-add.t @@ -13,6 +13,7 @@ my $ibx = { inboxdir => "$inboxdir/v2", name => 'test-v2writable', version => 2, + -no_fsync => 1, -primary_address => 'test@example.com', }; $ibx = PublicInbox::Inbox->new($ibx); diff --git a/t/v2mirror.t b/t/v2mirror.t index 12e3fcd0..012e5bd2 100644 --- a/t/v2mirror.t +++ b/t/v2mirror.t @@ -36,6 +36,7 @@ my $cfg = PublicInbox::Config->new($pi_config); my $ibx = $cfg->lookup('test@example.com'); ok($ibx, 'inbox found'); $ibx->{version} = 2; +$ibx->{-no_fsync} = 1; my $v2w = PublicInbox::V2Writable->new($ibx, 1); ok $v2w, 'v2w loaded'; $v2w->{parallel} = 0; diff --git a/t/v2reindex.t b/t/v2reindex.t index a931225c..1145e31b 100644 --- a/t/v2reindex.t +++ b/t/v2reindex.t @@ -18,6 +18,7 @@ my $ibx_config = { version => 2, -primary_address => 'test@example.com', indexlevel => 'full', + -no_fsync => 1, }; my $agpl = do { open my $fh, '<', 'COPYING' or die "can't open COPYING: $!"; diff --git a/t/v2writable.t b/t/v2writable.t index f0fa8a79..d9e7b980 100644 --- a/t/v2writable.t +++ b/t/v2writable.t @@ -17,6 +17,7 @@ my $ibx = { inboxdir => $inboxdir, name => 'test-v2writable', version => 2, + -no_fsync => 1, -primary_address => 'test@example.com', }; $ibx = PublicInbox::Inbox->new($ibx); diff --git a/t/watch_filter_rubylang.t b/t/watch_filter_rubylang.t index 29a9f793..5deb2082 100644 --- a/t/watch_filter_rubylang.t +++ b/t/watch_filter_rubylang.t @@ -74,6 +74,7 @@ publicinboxwatch.watchspam=maildir:$spamdir EOF my $cfg = PublicInbox::Config->new(\$orig); my $ibx = $cfg->lookup_name($v); + $ibx->{-no_fsync} = 1; ok($ibx, 'found inbox by name'); my $w = PublicInbox::Watch->new($cfg); @@ -103,6 +104,7 @@ EOF $cfg = PublicInbox::Config->new(\$orig); $ibx = $cfg->lookup_name($v); + $ibx->{-no_fsync} = 1; is($ibx->search->reopen->mset('b:spam')->size, 0, 'spam removed'); is_deeply([], \@warn, 'no warnings'); diff --git a/t/watch_maildir_v2.t b/t/watch_maildir_v2.t index 195e238b..7b46232b 100644 --- a/t/watch_maildir_v2.t +++ b/t/watch_maildir_v2.t @@ -47,6 +47,7 @@ EOF my $cfg = PublicInbox::Config->new(\$orig); my $ibx = $cfg->lookup_name('test'); ok($ibx, 'found inbox by name'); +$ibx->{-no_fsync} = 1; PublicInbox::Watch->new($cfg)->scan('full'); my $total = scalar @{$ibx->over->recent};