user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] www_attach: remove unnecessary parse_content_type import
Date: Thu, 11 Mar 2021 06:58:01 -0600	[thread overview]
Message-ID: <20210311125801.11169-1-e@80x24.org> (raw)

It's not needed since we have the handy eml->ct method.
---
 lib/PublicInbox/WwwAttach.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/PublicInbox/WwwAttach.pm b/lib/PublicInbox/WwwAttach.pm
index 93c43af8..a6c68a3f 100644
--- a/lib/PublicInbox/WwwAttach.pm
+++ b/lib/PublicInbox/WwwAttach.pm
@@ -6,7 +6,6 @@ package PublicInbox::WwwAttach; # internal package
 use strict;
 use parent qw(PublicInbox::GzipFilter);
 use bytes (); # only for bytes::length
-use PublicInbox::EmlContentFoo qw(parse_content_type);
 use PublicInbox::Eml;
 
 sub referer_match ($) {
@@ -31,9 +30,7 @@ sub get_attach_i { # ->each_part callback
 	return if $idx ne $ctx->{idx}; # [0-9]+(?:\.[0-9]+)+
 	my $res = $ctx->{res};
 	$res->[0] = 200;
-	my $ct = $part->content_type;
-	$ct = parse_content_type($ct) if $ct;
-
+	my $ct = $part->ct;
 	if ($ct && (($ct->{type} || '') eq 'text')) {
 		# display all text as text/plain:
 		my $cset = $ct->{attributes}->{charset};

                 reply	other threads:[~2021-03-11 12:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311125801.11169-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).