From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8846B1F9FD for ; Tue, 2 Mar 2021 09:13:07 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] inbox: ->mailboxid accessor Date: Tue, 2 Mar 2021 09:13:07 +0000 Message-Id: <20210302091307.19331-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This will be necessary for "mailboxIds" as described in RFCs 8620 and 8621 (for JMAP). We may implement "MAILBOXID" in RFC 8474 for IMAP, as well. --- lib/PublicInbox/Inbox.pm | 12 ++++++++++++ t/inbox.t | 7 +++++++ 2 files changed, 19 insertions(+) diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index a1e34797..da7ea75f 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -421,4 +421,16 @@ sub uidvalidity { $_[0]->{uidvalidity} //= eval { $_[0]->mm->created_at } } sub eidx_key { $_[0]->{newsgroup} // $_[0]->{inboxdir} } +sub mailboxid { # rfc 8474, 8620, 8621 + my ($self, $imap_slice) = @_; + my $pfx = defined($imap_slice) ? $self->{newsgroup} : $self->{name}; + utf8::encode($pfx); # to octets + # RFC 8620, 1.2 recommends not starting with dash or digits + # "A good solution to these issues is to prefix every id with a single + # alphabetical character." + 'M'.join('', map { sprintf('%02x', ord) } split(//, $pfx)) . + (defined($imap_slice) ? sprintf('-%x', $imap_slice) : '') . + sprintf('-%x', uidvalidity($self) // 0) +} + 1; diff --git a/t/inbox.t b/t/inbox.t index bc8fae9a..b7239e6d 100644 --- a/t/inbox.t +++ b/t/inbox.t @@ -32,4 +32,11 @@ is(unlink(glob("$x->{inboxdir}/*")), 2, 'unlinked cloneurl & description'); is_deeply($x->cloneurl, ['https://example.com/inbox'], 'cloneurls memoized'); is($x->description, "\x{100}blah", 'description memoized'); +$x->{name} = "2\x{100}wide"; +$x->{newsgroup} = '2.wide'; +like($x->mailboxid, qr/\AM32c48077696465-[0-9a-f]+\z/, + '->mailboxid w/o slice (JMAP)'); +like($x->mailboxid(78), qr/\AM322e77696465-4e-[0-9a-f]+\z/, + '->mailboxid w/ slice (IMAP)'); + done_testing();