From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1D0501F9FE for ; Wed, 24 Feb 2021 10:17:43 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lErEj-0000N3-Nh; Wed, 24 Feb 2021 11:17:41 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lErEj-0003zA-6N; Wed, 24 Feb 2021 11:17:41 +0100 Date: Wed, 24 Feb 2021 11:17:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH v2] www: use PublicInbox::WwwStream Message-ID: <20210224101741.strbpqg73wdsudcg@pengutronix.de> References: <20210224085456.77928-1-u.kleine-koenig@pengutronix.de> <20210224094750.GA26757@dcvr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3ffvljcfl7kmj72g" Content-Disposition: inline In-Reply-To: <20210224094750.GA26757@dcvr> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: meta@public-inbox.org List-Id: --3ffvljcfl7kmj72g Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 24, 2021 at 09:47:50AM +0000, Eric Wong wrote: > Uwe Kleine-K=F6nig wrote: > > This prevents the following problem logged to the webserver's error log: > >=20 > > E: Undefined subroutine &PublicInbox::WwwStream::code_footer called at= /usr/share/perl5/PublicInbox/WwwListing.pm line 102. > > in PublicInbox::ConfigIter=3DARRAY(0x557aea68b1a8)::each_section at /= usr/share/perl5/PublicInbox/ConfigIter.pm line 37. >=20 > Thanks, I tend to miss these errors since there's preloading > everywhere in tests to avoid startup penalties :x >=20 > > Fixes: 7a3946ef122e ("www: support listing of inboxes") > > --- > > Hello, > >=20 > > I fatfingered an additional ; in the (implicit) v1. :-\ >=20 > No worries, applied and pushed as a5af0bd94dc0504ec34d49199eb2b7d39ceb8557 > Thanks again. Great, note this is also relevant for the stable-1.6 branch. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --3ffvljcfl7kmj72g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmA2J8IACgkQwfwUeK3K 7AlFhgf/WIx6cAWJras/+S4T9eedDxZmQhS8hhhrx8tgfJSZD07I5WQ8jJOmW9Ij U7EcVG3Y9Dr0ZW3YH5u5Omxm5G5UTbcLpaZVNDc57D20IWX6FE45bdqvttZrj9CZ N7EEovlS3Vbv5tRJXj5gsoAgUVwptFFuh2G/aNRIUyXNCQJNMdt+edl2/RXcIIQ5 OQ98EEf9YOQg/lxF5vm6lDzW46yjHDXNZEZMxUCV/y2PpZigMQJg2dkr3SQUtD6e bXAP0Mo2zGex8Mdk3ut0Fa4oxfDVHh0jBE96Rf7Lo76GIpJ1bAtXZdf3fbGCPlap b0DJbZ7LdlSS//peLrNs7JrG+g7N1Q== =WHFE -----END PGP SIGNATURE----- --3ffvljcfl7kmj72g--