user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH v2] www: use PublicInbox::WwwStream
Date: Wed, 24 Feb 2021 11:17:41 +0100	[thread overview]
Message-ID: <20210224101741.strbpqg73wdsudcg@pengutronix.de> (raw)
In-Reply-To: <20210224094750.GA26757@dcvr>

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On Wed, Feb 24, 2021 at 09:47:50AM +0000, Eric Wong wrote:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > This prevents the following problem logged to the webserver's error log:
> > 
> > 	E: Undefined subroutine &PublicInbox::WwwStream::code_footer called at /usr/share/perl5/PublicInbox/WwwListing.pm line 102.
> > 	 in PublicInbox::ConfigIter=ARRAY(0x557aea68b1a8)::each_section at /usr/share/perl5/PublicInbox/ConfigIter.pm line 37.
> 
> Thanks, I tend to miss these errors since there's preloading
> everywhere in tests to avoid startup penalties :x
> 
> > Fixes: 7a3946ef122e ("www: support listing of inboxes")
> > ---
> > Hello,
> > 
> > I fatfingered an additional ; in the (implicit) v1. :-\
> 
> No worries, applied and pushed as a5af0bd94dc0504ec34d49199eb2b7d39ceb8557
> Thanks again.

Great, note this is also relevant for the stable-1.6 branch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-02-24 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  8:54 Uwe Kleine-König
2021-02-24  9:47 ` Eric Wong
2021-02-24 10:17   ` Uwe Kleine-König [this message]
2021-02-24 10:53     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224101741.strbpqg73wdsudcg@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH v2] www: use PublicInbox::WwwStream' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).