user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: meta@public-inbox.org
Subject: [PATCH v2] www: use PublicInbox::WwwStream
Date: Wed, 24 Feb 2021 09:54:56 +0100	[thread overview]
Message-ID: <20210224085456.77928-1-u.kleine-koenig@pengutronix.de> (raw)

This prevents the following problem logged to the webserver's error log:

	E: Undefined subroutine &PublicInbox::WwwStream::code_footer called at /usr/share/perl5/PublicInbox/WwwListing.pm line 102.
	 in PublicInbox::ConfigIter=ARRAY(0x557aea68b1a8)::each_section at /usr/share/perl5/PublicInbox/ConfigIter.pm line 37.

Fixes: 7a3946ef122e ("www: support listing of inboxes")
---
Hello,

I fatfingered an additional ; in the (implicit) v1. :-\

Best regards
Uwe

 lib/PublicInbox/WwwListing.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index d58618ccc01f..f28eddf1abb7 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -9,6 +9,7 @@ use PublicInbox::Hval qw(prurl fmt_ts);
 use PublicInbox::Linkify;
 use PublicInbox::GzipFilter qw(gzf_maybe);
 use PublicInbox::ConfigIter;
+use PublicInbox::WwwStream;
 use bytes (); # bytes::length
 
 sub ibx_entry {
-- 
2.30.0


             reply	other threads:[~2021-02-24  8:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  8:54 Uwe Kleine-König [this message]
2021-02-24  9:47 ` [PATCH v2] www: use PublicInbox::WwwStream Eric Wong
2021-02-24 10:17   ` Uwe Kleine-König
2021-02-24 10:53     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224085456.77928-1-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).