From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 09/10] lei convert: inline convert_start Date: Mon, 22 Feb 2021 08:22:58 -0300 Message-ID: <20210222112259.32402-9-e@80x24.org> (raw) In-Reply-To: <20210222112259.32402-1-e@80x24.org> Since we stopped using LeiAuth as a WQ worker, keeping this around as a single-use sub makes no sense and wastes several KB of memory. --- lib/PublicInbox/LeiConvert.pm | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/PublicInbox/LeiConvert.pm b/lib/PublicInbox/LeiConvert.pm index b45de4e0..4839dea4 100644 --- a/lib/PublicInbox/LeiConvert.pm +++ b/lib/PublicInbox/LeiConvert.pm @@ -62,17 +62,6 @@ sub do_convert { # via wq_do delete $self->{wcb}; # commit } -sub convert_start { - my ($lei) = @_; - my $self = $lei->{cnv}; - my $op = $lei->workers_start($self, 'lei_convert', 1, { - '' => [ $lei->can('dclose'), $lei ] - }); - $self->wq_io_do('do_convert', []); - $self->wq_close(1); - while ($op && $op->{sock}) { $op->event_step } -} - sub call { # the main "lei convert" method my ($cls, $lei, @inputs) = @_; my $opt = $lei->{opt}; @@ -131,7 +120,12 @@ sub call { # the main "lei convert" method $nrd->{quiet} = $opt->{quiet}; $lei->{nrd} = $nrd; } - convert_start($lei); + my $op = $lei->workers_start($self, 'lei_convert', 1, { + '' => [ $lei->can('dclose'), $lei ] + }); + $self->wq_io_do('do_convert', []); + $self->wq_close(1); + while ($op && $op->{sock}) { $op->event_step } } sub ipc_atfork_child {
next prev parent reply other threads:[~2021-02-22 11:23 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-22 11:21 [PATCH 00/10] lei: avoid wasting IMAP connections Eric Wong 2021-02-22 11:22 ` [PATCH 01/10] lei_auth: rename {nrd} field to {net} for clarity Eric Wong 2021-02-22 11:22 ` [PATCH 02/10] lei: keep client {sock} in short-lived workers Eric Wong 2021-02-22 11:22 ` [PATCH 03/10] lei: _lei_cfg: return empty hashref if unconfigured Eric Wong 2021-02-22 11:22 ` [PATCH 04/10] lei convert: auth directly from worker process Eric Wong 2021-02-22 11:22 ` [PATCH 05/10] lei import: no separate auth worker Eric Wong 2021-02-22 11:22 ` [PATCH 06/10] lei_auth: migrate common auth code from lei_import Eric Wong 2021-02-22 11:22 ` [PATCH 07/10] lei q: reduce wasted IMAP connection for auth Eric Wong 2021-02-22 11:22 ` [PATCH 08/10] net_reader: mic_get: reuse connections if cache enabled Eric Wong 2021-02-22 11:22 ` Eric Wong [this message] 2021-02-22 11:22 ` [PATCH 10/10] lei_auth: trim and remove leftover worker code Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210222112259.32402-9-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 09/10] lei convert: inline convert_start' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
user/dev discussion of public-inbox itself This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/meta git clone --mirror http://czquwvybam4bgbro.onion/meta git clone --mirror http://hjrcffqmbrq6wope.onion/meta git clone --mirror http://ou63pmih66umazou.onion/meta # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 meta meta/ https://public-inbox.org/meta \ meta@public-inbox.org public-inbox-index meta Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta nntp://news.gmane.io/gmane.mail.public-inbox.general note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git