From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4EA5E1FC0B for ; Mon, 22 Feb 2021 11:23:00 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 08/10] net_reader: mic_get: reuse connections if cache enabled Date: Mon, 22 Feb 2021 08:22:57 -0300 Message-Id: <20210222112259.32402-8-e@80x24.org> In-Reply-To: <20210222112259.32402-1-e@80x24.org> References: <20210222112155.32231-1-e@80x24.org> <20210222112259.32402-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We only enable {mic_cached} in WQ workers, and those aren't expected to fork again going forward. So cache here avoid a penalty for the non-augmenting (imap_delete_all) call with "lei q" --- lib/PublicInbox/NetReader.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm index c29e09c1..ff90468b 100644 --- a/lib/PublicInbox/NetReader.pm +++ b/lib/PublicInbox/NetReader.pm @@ -426,7 +426,8 @@ sub mic_get { my ($self, $uri) = @_; my $sec = uri_section($uri); # see if caller saved result of imap_common_init - if (my $cached = $self->{mics_cached}) { + my $cached = $self->{mics_cached}; + if ($cached) { my $mic = $cached->{$sec}; return $mic if $mic && $mic->IsConnected; delete $cached->{$sec}; @@ -439,7 +440,8 @@ sub mic_get { } } my $mic = PublicInbox::IMAPClient->new(%$mic_arg); - $mic && $mic->IsConnected ? $mic : undef; + $cached //= {}; # invalid placeholder if no cache enabled + $mic && $mic->IsConnected ? ($cached->{$sec} = $mic) : undef; } sub imap_each {