From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 08/10] net_reader: mic_get: reuse connections if cache enabled Date: Mon, 22 Feb 2021 08:22:57 -0300 [thread overview] Message-ID: <20210222112259.32402-8-e@80x24.org> (raw) In-Reply-To: <20210222112259.32402-1-e@80x24.org> We only enable {mic_cached} in WQ workers, and those aren't expected to fork again going forward. So cache here avoid a penalty for the non-augmenting (imap_delete_all) call with "lei q" --- lib/PublicInbox/NetReader.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm index c29e09c1..ff90468b 100644 --- a/lib/PublicInbox/NetReader.pm +++ b/lib/PublicInbox/NetReader.pm @@ -426,7 +426,8 @@ sub mic_get { my ($self, $uri) = @_; my $sec = uri_section($uri); # see if caller saved result of imap_common_init - if (my $cached = $self->{mics_cached}) { + my $cached = $self->{mics_cached}; + if ($cached) { my $mic = $cached->{$sec}; return $mic if $mic && $mic->IsConnected; delete $cached->{$sec}; @@ -439,7 +440,8 @@ sub mic_get { } } my $mic = PublicInbox::IMAPClient->new(%$mic_arg); - $mic && $mic->IsConnected ? $mic : undef; + $cached //= {}; # invalid placeholder if no cache enabled + $mic && $mic->IsConnected ? ($cached->{$sec} = $mic) : undef; } sub imap_each {
next prev parent reply other threads:[~2021-02-22 11:23 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-22 11:21 [PATCH 00/10] lei: avoid wasting IMAP connections Eric Wong 2021-02-22 11:22 ` [PATCH 01/10] lei_auth: rename {nrd} field to {net} for clarity Eric Wong 2021-02-22 11:22 ` [PATCH 02/10] lei: keep client {sock} in short-lived workers Eric Wong 2021-02-22 11:22 ` [PATCH 03/10] lei: _lei_cfg: return empty hashref if unconfigured Eric Wong 2021-02-22 11:22 ` [PATCH 04/10] lei convert: auth directly from worker process Eric Wong 2021-02-22 11:22 ` [PATCH 05/10] lei import: no separate auth worker Eric Wong 2021-02-22 11:22 ` [PATCH 06/10] lei_auth: migrate common auth code from lei_import Eric Wong 2021-02-22 11:22 ` [PATCH 07/10] lei q: reduce wasted IMAP connection for auth Eric Wong 2021-02-22 11:22 ` Eric Wong [this message] 2021-02-22 11:22 ` [PATCH 09/10] lei convert: inline convert_start Eric Wong 2021-02-22 11:22 ` [PATCH 10/10] lei_auth: trim and remove leftover worker code Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210222112259.32402-8-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 08/10] net_reader: mic_get: reuse connections if cache enabled' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).