From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 6ACE71F9FD;
	Sun, 21 Feb 2021 22:02:39 +0000 (UTC)
Date: Sun, 21 Feb 2021 22:02:39 +0000
From: Eric Wong <e@80x24.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 1/3] t/www_listing: correct the number of tests for
 grok-pull skip
Message-ID: <20210221220239.GA24690@dcvr>
References: <20210221214612.15071-1-kyle@kyleam.com>
 <20210221214612.15071-2-kyle@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210221214612.15071-2-kyle@kyleam.com>
List-Id: <meta.public-inbox.org>

Kyle Meyer <kyle@kyleam.com> wrote:
> ---
> 
>   I'm not positive that I'm understanding skip's $how_many argument or
>   that it matters much.

It doesn't seem to matter, anymore.

In the old days, Test::More required explicit plan test counts
for everything, but we've always relied on done_testing() (no
args) in our code base with no explicit plan.

I've given up maintaining counts inside test_lei; and
just using `1'.  I suppose it's safe to do for the rest
of our tests, but I'm not against this patch, either.