From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id EFBC11F9FD for ; Thu, 18 Feb 2021 12:27:09 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] lei: completion: bash: generalize nospace usage Date: Thu, 18 Feb 2021 18:27:09 +0600 Message-Id: <20210218122709.18097-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We'll be completing more options with ':', '//' and '=' in the future, so make it easier to disable trailing spaces on completions. --- contrib/completion/lei-completion.bash | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/contrib/completion/lei-completion.bash b/contrib/completion/lei-completion.bash index 619805fb..2c28d44a 100644 --- a/contrib/completion/lei-completion.bash +++ b/contrib/completion/lei-completion.bash @@ -4,14 +4,12 @@ # preliminary bash completion support for lei (Local Email Interface) # Needs a lot of work, see `lei__complete' in lib/PublicInbox::LEI.pm _lei() { - case ${COMP_WORDS[@]} in - *' add-external h'* | *' --mirror h'*) - compopt -o nospace - ;; + local wordlist="$(lei _complete ${COMP_WORDS[@]})" + case $wordlist in + *':'* | *'='* | '//'*) compopt -o nospace ;; *) compopt +o nospace ;; # the default esac - COMPREPLY=($(compgen -W "$(lei _complete ${COMP_WORDS[@]})" \ - -- "${COMP_WORDS[COMP_CWORD]}")) + COMPREPLY=($(compgen -W "$wordlist" -- "${COMP_WORDS[COMP_CWORD]}")) return 0 } complete -o default -o bashdefault -F _lei lei