user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] pkt_op: do not exit subroutine via "next"
@ 2021-02-04  2:06 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-02-04  2:06 UTC (permalink / raw)
  To: meta

"next" apparently doesn't work in "do {} while" loops,
so just use "while" as it makes no difference, here.
---
 lib/PublicInbox/PktOp.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/PktOp.pm b/lib/PublicInbox/PktOp.pm
index 10d76da0..5d8e78ea 100644
--- a/lib/PublicInbox/PktOp.pm
+++ b/lib/PublicInbox/PktOp.pm
@@ -48,7 +48,7 @@ sub event_step {
 	my ($self) = @_;
 	my $c = $self->{sock};
 	my $msg;
-	do {
+	while (1) {
 		my $n = recv($c, $msg, 4096, 0);
 		unless (defined $n) {
 			return if $! == EAGAIN;
@@ -70,7 +70,7 @@ sub event_step {
 		my ($sub, @args) = @$op;
 		$sub->(@args, @pargs);
 		return $self->close if $msg eq ''; # close on EOF
-	} while (1);
+	}
 }
 
 1;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-04  2:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04  2:06 [PATCH] pkt_op: do not exit subroutine via "next" Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).