From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 10/11] lei: use sleep(1) loop for infinite sleep Date: Tue, 2 Feb 2021 22:11:42 -1000 [thread overview] Message-ID: <20210203081143.24424-11-e@80x24.org> (raw) In-Reply-To: <20210203081143.24424-1-e@80x24.org> Perl may internally race and miss signals due to a lack of self-pipe / eventfd / signalfd / EVFILT_SIGNAL usage. While our event loop paths avoid these problems by using signalfd or EVFILT_SIGNAL, thse sleep() calls are not within the event loop. --- lib/PublicInbox/LEI.pm | 2 +- script/lei | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 005f6f7a..28dce0c5 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -299,7 +299,7 @@ sub x_it ($$) { if (my $signum = ($code & 127)) { # usually SIGPIPE (13) $SIG{PIPE} = 'DEFAULT'; # $SIG{$signum} doesn't work kill $signum, $$; - sleep; # wait for signal + sleep(1) while 1; # wait for signal } else { $quit->($code >> 8); } diff --git a/script/lei b/script/lei index 58f0dbe9..40c21ad8 100755 --- a/script/lei +++ b/script/lei @@ -116,7 +116,7 @@ Falling back to (slow) one-shot mode sigchld(); if (my $sig = ($x_it_code & 127)) { kill $sig, $$; - sleep; + sleep(1) while 1; } exit($x_it_code >> 8); } else { # for systems lacking Socket::MsgHdr or Inline::C
next prev parent reply other threads:[~2021-02-03 8:11 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-03 8:11 [PATCH 00/11] lei q --stdin, shortcut names, etc Eric Wong 2021-02-03 8:11 ` [PATCH 01/11] lei: reduce FD pressure from lei2mail worker Eric Wong 2021-02-03 8:11 ` [PATCH 02/11] lei: further reduce lei2mail FD pressure Eric Wong 2021-02-03 8:11 ` [PATCH 03/11] pkt_op: rely on DS::in_loop global Eric Wong 2021-02-03 8:11 ` [PATCH 04/11] lei: err: avoid uninitialized variable warnings Eric Wong 2021-02-03 8:11 ` [PATCH 05/11] lei: propagate curl errors, improve internal consistency Eric Wong 2021-02-03 8:11 ` [PATCH 06/11] lei q: -I/--exclude/--only support globs and basenames Eric Wong 2021-02-03 8:11 ` [PATCH 07/11] lei: complete basenames for include|exclude|only Eric Wong 2021-02-03 8:11 ` [PATCH 08/11] lei: help starts pager Eric Wong 2021-02-03 8:11 ` [PATCH 09/11] lei add-external: completion for existing URL basenames Eric Wong 2021-02-03 8:11 ` Eric Wong [this message] 2021-02-03 8:11 ` [PATCH 11/11] lei q: support reading queries from stdin Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210203081143.24424-11-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 10/11] lei: use sleep(1) loop for infinite sleep' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).