From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id CFC7320086 for ; Tue, 2 Feb 2021 11:47:03 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 14/16] lei_overview: avoid unnecessary {l2m} delete Date: Tue, 2 Feb 2021 11:47:00 +0000 Message-Id: <20210202114702.29886-15-e@80x24.org> In-Reply-To: <20210202114702.29886-1-e@80x24.org> References: <20210202114702.29886-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We may reuse these objects in the non-worker code paths. --- lib/PublicInbox/LeiOverview.pm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm index 31cc67f1..ff15d295 100644 --- a/lib/PublicInbox/LeiOverview.pm +++ b/lib/PublicInbox/LeiOverview.pm @@ -147,10 +147,8 @@ sub _unbless_smsg { sub ovv_atexit_child { my ($self, $lei) = @_; - if (my $l2m = delete $lei->{l2m}) { - # gracefully stop lei2mail processes after all - # ->write_mail work is complete - delete $l2m->{-wq_s1}; + if (my $l2m = $lei->{l2m}) { + # wait for ->write_mail work we submitted to lei2mail if (my $rd = delete $l2m->{each_smsg_done}) { read($rd, my $buf, 1); # wait for EOF }