From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4AFCD1FA13 for ; Mon, 25 Jan 2021 06:41:59 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/4] spawn: split() on regexp, not a literal string Date: Sun, 24 Jan 2021 22:41:57 -0800 Message-Id: <20210125064158.15179-4-e@80x24.org> In-Reply-To: <20210125064158.15179-1-e@80x24.org> References: <20210125064158.15179-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It doesn't appear Perl (as of 5.32.x) has any internal optimization for splitting on a single-byte, so give it a regexp instead of letting it compile and discard a new one every single time. --- lib/PublicInbox/Spawn.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm index 376d2190..86f66605 100644 --- a/lib/PublicInbox/Spawn.pm +++ b/lib/PublicInbox/Spawn.pm @@ -343,7 +343,7 @@ undef $fdpass; sub which ($) { my ($file) = @_; return $file if index($file, '/') >= 0; - foreach my $p (split(':', $ENV{PATH})) { + for my $p (split(/:/, $ENV{PATH})) { $p .= "/$file"; return $p if -x $p; }