user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 3/4] spawn: split() on regexp, not a literal string
Date: Sun, 24 Jan 2021 22:41:57 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

It doesn't appear Perl (as of 5.32.x) has any internal
optimization for splitting on a single-byte, so give it
a regexp instead of letting it compile and discard a
new one every single time.
 lib/PublicInbox/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 376d2190..86f66605 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -343,7 +343,7 @@ undef $fdpass;
 sub which ($) {
 	my ($file) = @_;
 	return $file if index($file, '/') >= 0;
-	foreach my $p (split(':', $ENV{PATH})) {
+	for my $p (split(/:/, $ENV{PATH})) {
 		$p .= "/$file";
 		return $p if -x $p;

  parent reply	other threads:[~2021-01-25  6:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25  6:41 [PATCH 0/4] miscidx: lazy transactions to fix tests Eric Wong
2021-01-25  6:41 ` [PATCH 1/4] lei: use Time::HiRes stat for nanosecond resolution Eric Wong
2021-01-25  6:41 ` [PATCH 2/4] miscidx: switch to lazy transactions Eric Wong
2021-01-25  6:41 ` Eric Wong [this message]
2021-01-25  6:41 ` [PATCH 4/4] use defined-or in a few more places Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).