From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/5] t/thread-index-gap: support older DBI
Date: Sun, 17 Jan 2021 07:09:57 +0000 [thread overview]
Message-ID: <20210117070959.16826-4-e@80x24.org> (raw)
In-Reply-To: <20210117070959.16826-1-e@80x24.org>
From: Eric Wong <e@yhbt.net>
...by avoiding selectall_array in favor of selectall_arrayref.
Tested with DBI 1.627.
---
t/thread-index-gap.t | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/t/thread-index-gap.t b/t/thread-index-gap.t
index f4e4bd09..83c3707d 100644
--- a/t/thread-index-gap.t
+++ b/t/thread-index-gap.t
@@ -45,12 +45,15 @@ for my $msgs (['orig', reverse @msgs], ['shuffle', shuffle(@msgs)]) {
}
$im->done;
my $over = $ibx->over;
- my @tid = $over->dbh->selectall_array('SELECT DISTINCT(tid) FROM over');
+ my $dbh = $over->dbh;
+ my $tid = $dbh->selectall_arrayref('SELECT DISTINCT(tid) FROM over');
+ my @tid = map { $_->[0] } @$tid;
is(scalar(@tid), 1, "only one thread initially ($desc)");
$over->dbh_close;
run_script([qw(-index --reindex --rethread), $ibx->{inboxdir}]) or
BAIL_OUT 'rethread';
- @tid = $over->dbh->selectall_array('SELECT DISTINCT(tid) FROM over');
+ $tid = $dbh->selectall_arrayref('SELECT DISTINCT(tid) FROM over');
+ @tid = map { $_->[0] } @$tid;
is(scalar(@tid), 1, "only one thread after rethread ($desc)");
}
next prev parent reply other threads:[~2021-01-17 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 7:09 [PATCH 0/5] fixes for older Perls and Xapian Eric Wong
2021-01-17 7:09 ` [PATCH 1/5] address: pairs: enable pure Perl version Eric Wong
2021-01-17 7:09 ` [PATCH 2/5] initialize scalar for `vec' perlop modification Eric Wong
2021-01-17 7:09 ` Eric Wong [this message]
2021-01-17 7:09 ` [PATCH 4/5] t/shared_kv: workaround old File::Spec Eric Wong
2021-01-17 7:09 ` [PATCH 5/5] extindex: fix w/ Xapian 1.2.21..1.2.24 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210117070959.16826-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).