From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2BC251FA18 for ; Sat, 2 Jan 2021 09:13:45 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 5/6] git: manifest_entry: use ProcessPipe via popen_rd Date: Fri, 1 Jan 2021 19:13:43 -1400 Message-Id: <20210102091344.13477-6-e@80x24.org> In-Reply-To: <20210102091344.13477-1-e@80x24.org> References: <20210102091344.13477-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Only saves us one line of code, but that's better than nothing. --- lib/PublicInbox/Git.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index cdd2b400..3d97300c 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -507,14 +507,13 @@ sub modified ($) { # templates/this--description in git.git sub manifest_entry { my ($self, $epoch, $default_desc) = @_; - my ($fh, $pid) = $self->popen('show-ref'); + my $fh = $self->popen('show-ref'); my $dig = Digest::SHA->new(1); while (read($fh, my $buf, 65536)) { $dig->add($buf); } - close $fh; - waitpid($pid, 0); - return if $?; # empty, uninitialized git repo + close $fh or return; # empty, uninitialized git repo + undef $fh; # for open, below my $git_dir = $self->{git_dir}; my $ent = { fingerprint => $dig->hexdigest,