user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/2] git: some safety fixes
Date: Sun, 29 Nov 2020 10:52:28 +0000	[thread overview]
Message-ID: <20201129105230.12501-1-e@80x24.org> (raw)

I noticed -imapd on public-inbox.org was stuck reading on the
Gcf2 pipe; so patch 1/2 should allow us to recover within 60s if
it happens again.

And 2/2 makes the code easier to follow/modify in case we do
hit failures, since we need to ensure we call DS::close in the
daemons.

Not sure what caused that read(2) to get stuck, I reread the
partial writev calculations in lib/PublicInbox/gcf2_libgit2.h
and it all seems to make sense to me.  I've also written and
tested similar code for writev/sendmmsg many times over the
years in other projects...

Eric Wong (2):
  git: set non-blocking flag in case of other bugs
  git: ensure subclassed ->fail gets called

 lib/PublicInbox/Git.pm         | 52 +++++++++++++++++++++-------------
 lib/PublicInbox/GitAsyncCat.pm |  6 +---
 2 files changed, 34 insertions(+), 24 deletions(-)

             reply	other threads:[~2020-11-29 10:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 10:52 Eric Wong [this message]
2020-11-29 10:52 ` [PATCH 1/2] git: set non-blocking flag in case of other bugs Eric Wong
2020-11-29 10:52 ` [PATCH 2/2] git: ensure subclassed ->fail gets called Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129105230.12501-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).