user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH v2] searchidx: check for graceful shutdown in log2stack
Date: Sun, 15 Nov 2020 23:20:17 +0000
Message-ID: <20201115232017.GA13149@dcvr> (raw)
In-Reply-To: <>

The initial "git log" invocation for a git epoch can be time
consuming, so check for graceful shutdown at each line to ensure
timely shutdowns and avoid SSD/HDD wear.
 v2: much simpler than v1, since log2stack and prepare_stack
     callers already understand a `undef' return value.

 lib/PublicInbox/ | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 90d8c8b3..6ff2cf94 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -753,6 +753,7 @@ sub log2stack ($$$) {
 	my ($at, $ct, $stk, $cmt);
 	while (<$fh>) {
+		return if $sync->{quit};
 		if (/\A([0-9]+)-([0-9]+)-($OID)$/o) {
 			($at, $ct, $cmt) = ($1 + 0, $2 + 0, $3);
 			$stk //= PublicInbox::IdxStack->new($cmt);

      reply	other threads:[~2020-11-15 23:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15  9:16 [PATCH] " Eric Wong
2020-11-15 23:20 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201115232017.GA13149@dcvr \ \ \
    --subject='Re: [PATCH v2] searchidx: check for graceful shutdown in log2stack' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ \
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone