From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 80AEA1F66F;
	Sun, 15 Nov 2020 03:03:26 +0000 (UTC)
Date: Sun, 15 Nov 2020 03:03:25 +0000
From: Eric Wong <e@80x24.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 2/4] *index: avoid per-epoch --batch-check processes
Message-ID: <20201115030325.GA2611@dcvr>
References: <20201113111144.23038-1-e@80x24.org>
 <20201113111144.23038-3-e@80x24.org>
 <877dqpig9j.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <877dqpig9j.fsf@kyleam.com>
List-Id: <meta.public-inbox.org>

Kyle Meyer <kyle@kyleam.com> wrote:
> [ superficial typo comments from a reader who is out of his depth :) ]

They're greatly appreciated.  My brain is working worse than
usual these days, so extra eyes anywhere are appreciated.  And
trying to get my mind off crap by trying something new caused me
to hit my head, so maybe I'm concussed, too :x

> Eric Wong writes:
> 
> > Since all.git (v2) and ALL.git (extindex) encompass every single
> > epoch or indexed inbox; and we is_ancestor() only uses
> 
> s/we is_ancestor/is_ancestor/?

yup

> > hexadecimal OIDs, there is no good reason to to use $unit->{git}
> > for an epoch-local $git->check avoids redundant long-lived
> > processes.
> 
> s/to to/to/
> 
> I'm having trouble parsing that last part.  Perhaps the "avoids ..." is
> covered by the next paragraph and should be dropped?

Agreed, dropped that bit.

> s/an several/several/

Thanks