Re: [PATCH] nntp: delimit Newsgroup: header with commas

[Eric Wong <e@80x24.org>]

Andrey Melnikov <temnota.am@gmail.com> wrote:
> ????, 4 ????????. 2020 ??. ?? 22:47, Eric Wong <e@80x24.org>:
> >
> > Andrey Melnikov <temnota.am@gmail.com> wrote:
> > > ????, 4 ????????. 2020 ??. ?? 13:44, Eric Wong <e@80x24.org>:
> > > > I suppose a few extra bytes won't hurt, too much :x
> > >
> > > Current:
> > > Path: y
> > >         org.linuxdriverproject.driverdev-devel:35214
> > >         org.kernel.vger.linux-devicetree:433117
> > >         org.kernel.vger.linux-kernel:3765410
> > >         org.kernel.vger.linux-media:192196
> >
> > Huh?  From what I can see, the last 4 lines are part of the
> > Xref: header, which is unchanged atm (I plan on speeding it up
> > with extindex, though).
> 
> Yeah, leafnode rewrite Xref: header..
> -- raw --
> Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
> Path: y
> Xref: nntp://nntp.lore.kernel.org
>     org.linuxdriverproject.driverdev-devel:35265
>     org.kernel.vger.linux-devicetree:433316
>     org.kernel.vger.linux-kernel:3766059
>     org.kernel.vger.linux-mmc:59564
>     org.kernel.vger.linux-wireless:204883
>     org.kernel.vger.netdev:733193
> Newsgroups: org.linuxdriverproject.driverdev-devel
>     org.kernel.vger.linux-devicetree
>     org.kernel.vger.linux-kernel org.kernel.vger.linux-mmc
>     org.kernel.vger.linux-wireless org.kernel.vger.netdev
> Archived-At: <https://lore.kernel.org/driverdev-devel/20201104191554.GA3972736@bogus/>
> List-Archive: <https://lore.kernel.org/driverdev-devel/>
> -- on disk --
> Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
> Path: y
>         org.linuxdriverproject.driverdev-devel:35265
>         org.kernel.vger.linux-devicetree:433316
>         org.kernel.vger.linux-kernel:3766059
>         org.kernel.vger.linux-mmc:59564
>         org.kernel.vger.linux-wireless:204883
>         org.kernel.vger.netdev:733193
> Newsgroups: org.linuxdriverproject.driverdev-devel
>         org.kernel.vger.linux-devicetree
>         org.kernel.vger.linux-kernel org.kernel.vger.linux-mmc
>         org.kernel.vger.linux-wireless org.kernel.vger.netdev
> Archived-At: <https://lore.kernel.org/driverdev-devel/20201104191554.GA3972736@bogus/>
> List-Archive: <https://lore.kernel.org/driverdev-devel/>
> Xref: news.localnet org.linuxdriverproject.driverdev-devel:4323
> ---
> Haha. It simply does not expect folded multiline Xref:  header. And
> generate by itself a new (unfolded, separated by space) header when
> storing article on disk.
> Is really Newsgroups: & Xref: headers need folding?

Nope, but currently PublicInbox::Eml folds by default
(and Email::MIME/Email::Simple did in ->as_string, too).

I didn't expect clients to have problems with folded lines since
Received: and Cc: are often folded, anyways.

Does leafnode struggle with those headers?  Or just Newsgroups/Xref?

We may need a separate API method for setting NNTP-only headers
to appease leafnode...

> 
> > > and new:
> > > Path: nntp.lore.kernel.org!not.for.mail
> > > save more extra bytes...
> > >
> > > Hehe... yet another cosmetic thing:
> > > $ telnet nntp.lore.kernel.org 119
> > > Trying 54.189.247.149...
> > > Connected to korg-lkml-1-news-lb-839eef9f3a4cef4e.elb.us-west-2.amazonaws.com.
> > > Escape character is '^]'.
> > > 201 nntp://nntp.lore.kernel.org ready - post via email
> > > quit
> > > Connection closed by foreign host.
> > >
> > > 'nntp://nntp.lore.kernel.org' is not a node name per RFC... But this
> > > is a configuration problem on nntp.lore.kernel.org side.
> >
> > You can notify helpdesk@kernel.org to get it fixed.
> 
> This is cosmetics. nntp readers do not use this hostname.

It may be nice to extract hostname from URI, anyways, since it
should be possible to advertise NNTPS endpoint in the WWW UI.