user/dev discussion of public-inbox itself
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH] gcf2: improve error handling and do not ->fail on wbuf
Date: Mon, 28 Sep 2020 05:52:43 +0000
Message-ID: <20200928055243.GA79500@dcvr> (raw)
In-Reply-To: <20200927221248.28815-1-e@80x24.org>

Putting words together to write commit messages is hard
without enough sleep :<

Anyways, revised and pushed as
commit 8ba04f214bbadcbe106c94281a0c4c21dd50adb8

    gcf2: improve error handling and do not ->fail on wbuf
    
    For historical reasons, both Danga::Socket::write and
    PublicInbox::DS::write will return 0 when data is buffered;
    so Gcf2Client must not call ->fail when DS::write returns 0.
    
    We'll also improve robustness by recreating the entire
    Gcf2Client object if it does die for other reasons, instead of
    risking mismatched fields due to deferred close.
    
    We also need to ensure we only get one EPOLLERR wakeup and
    issue EPOLL_CTL_DEL if ->event_step is triggered by a dying
    Gcf2 process, so always register the FD with EPOLLONESHOT.

      reply	other threads:[~2020-09-28  5:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27 22:12 Eric Wong
2020-09-28  5:52 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928055243.GA79500@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ https://public-inbox.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git