From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 619941FA10 for ; Tue, 22 Sep 2020 18:49:51 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/2] v2writable: drop outdated {unindex_range} check Date: Tue, 22 Sep 2020 18:49:50 +0000 Message-Id: <20200922184950.17868-3-e@80x24.org> In-Reply-To: <20200922184950.17868-1-e@80x24.org> References: <20200922184950.17868-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: {unindex_range} only exists in the $sync state, nowadays, not the V2Writable ($self) object. $sync->{unindex_range} won't be populated if $regen_max is zero, either, unless somebody is injecting importable commits into an epoch history, in which this change will result in no-op indexing doing no work. --- lib/PublicInbox/V2Writable.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index b8abfa94..5ff2af10 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -1074,7 +1074,7 @@ sub sync_prepare ($$$) { } $all->cat_async_wait; } - if (!$regen_max && !keys(%{$self->{unindex_range}})) { + if (!$regen_max) { $sync->{-regen_fmt} = "%u/?\n"; return 0; }