user/dev discussion of public-inbox itself
 help / color / mirror / Atom feed
* [PATCH 0/2] more minor indexing fixes
@ 2020-09-22 18:49 Eric Wong
  2020-09-22 18:49 ` [PATCH 1/2] idxstack: fix comment about file_char Eric Wong
  2020-09-22 18:49 ` [PATCH 2/2] v2writable: drop outdated {unindex_range} check Eric Wong
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Wong @ 2020-09-22 18:49 UTC (permalink / raw)
  To: meta

Stuff noticed while working on detached index usability
and maintainability...

Eric Wong (2):
  idxstack: fix comment about file_char
  v2writable: drop outdated {unindex_range} check

 lib/PublicInbox/IdxStack.pm   | 2 +-
 lib/PublicInbox/V2Writable.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] idxstack: fix comment about file_char
  2020-09-22 18:49 [PATCH 0/2] more minor indexing fixes Eric Wong
@ 2020-09-22 18:49 ` Eric Wong
  2020-09-22 18:49 ` [PATCH 2/2] v2writable: drop outdated {unindex_range} check Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Wong @ 2020-09-22 18:49 UTC (permalink / raw)
  To: meta

It's `d' for deletes, not `a'.
---
 lib/PublicInbox/IdxStack.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/IdxStack.pm b/lib/PublicInbox/IdxStack.pm
index b43b8064..ce75b46a 100644
--- a/lib/PublicInbox/IdxStack.pm
+++ b/lib/PublicInbox/IdxStack.pm
@@ -14,7 +14,7 @@ sub new {
 	bless { wr => $io, latest_cmt => $_[1] }, __PACKAGE__
 }
 
-# file_char = [a|m]
+# file_char = [d|m]
 sub push_rec {
 	my ($self, $file_char, $at, $ct, $blob_oid) = @_;
 	my $rec = pack(FMT, $file_char, $at, $ct, $blob_oid);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] v2writable: drop outdated {unindex_range} check
  2020-09-22 18:49 [PATCH 0/2] more minor indexing fixes Eric Wong
  2020-09-22 18:49 ` [PATCH 1/2] idxstack: fix comment about file_char Eric Wong
@ 2020-09-22 18:49 ` Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Wong @ 2020-09-22 18:49 UTC (permalink / raw)
  To: meta

{unindex_range} only exists in the $sync state, nowadays, not the
V2Writable ($self) object.  $sync->{unindex_range} won't be
populated if $regen_max is zero, either, unless somebody is
injecting importable commits into an epoch history, in which
this change will result in no-op indexing doing no work.
---
 lib/PublicInbox/V2Writable.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index b8abfa94..5ff2af10 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1074,7 +1074,7 @@ sub sync_prepare ($$$) {
 		}
 		$all->cat_async_wait;
 	}
-	if (!$regen_max && !keys(%{$self->{unindex_range}})) {
+	if (!$regen_max) {
 		$sync->{-regen_fmt} = "%u/?\n";
 		return 0;
 	}

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-22 18:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 18:49 [PATCH 0/2] more minor indexing fixes Eric Wong
2020-09-22 18:49 ` [PATCH 1/2] idxstack: fix comment about file_char Eric Wong
2020-09-22 18:49 ` [PATCH 2/2] v2writable: drop outdated {unindex_range} check Eric Wong

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ https://public-inbox.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git