From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id B975D1F4B4
	for <meta@public-inbox.org>; Sun, 20 Sep 2020 01:43:15 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] config: warn on multiple values for some fields
Date: Sun, 20 Sep 2020 01:43:15 +0000
Message-Id: <20200920014315.29934-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

Our code doesn't support multi-values for these, and having
unexpected arrays leads to unexpected results (e.g. showing
stuff like "ARRAY(0xDEADBEEFADD12E55)" in user interfaces).  So
warn and only use the last value (matching git-config(1)
behavior without `--get-all').
---
 lib/PublicInbox/Config.pm | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 8ccf337d..abc525db 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -364,13 +364,23 @@ sub _fill {
 	my ($self, $pfx) = @_;
 	my $ibx = {};
 
-	foreach my $k (qw(inboxdir filter newsgroup
-			watch httpbackendmax
-			replyto feedmax nntpserver
-			indexlevel indexsequentialshard)) {
+	for my $k (qw(watch nntpserver)) {
 		my $v = $self->{"$pfx.$k"};
 		$ibx->{$k} = $v if defined $v;
 	}
+	for my $k (qw(filter inboxdir newsgroup replyto httpbackendmax feedmax
+			indexlevel indexsequentialshard)) {
+		if (defined(my $v = $self->{"$pfx.$k"})) {
+			if (ref($v) eq 'ARRAY') {
+				warn <<EOF;
+W: $pfx.$k has multiple values, only using `$v->[-1]'
+EOF
+				$ibx->{$k} = $v->[-1];
+			} else {
+				$ibx->{$k} = $v;
+			}
+		}
+	}
 
 	# backwards compatibility:
 	$ibx->{inboxdir} //= $self->{"$pfx.mainrepo"};