user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] t/imapd.t: skip dependent test on failure
@ 2020-09-14 21:29 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-09-14 21:29 UTC (permalink / raw)
  To: meta

We don't want to cascade failures/warnings when something else
breaks.  There's likely more of these to be fixed as we
encounter them.
---
 t/imapd.t | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/t/imapd.t b/t/imapd.t
index f743bf06..cb95fa5d 100644
--- a/t/imapd.t
+++ b/t/imapd.t
@@ -404,8 +404,11 @@ SKIP: {
 	skip 'Xapian missing', 3 if $level eq 'basic';
 	my $x = $mic->search(qw(header subject embedded));
 	is(scalar(@$x), 1, 'MSN SEARCH on Subject works after rm');
-	$x = $mic->message_string($x->[0]);
-	is($x, $ret->{2}->{RFC822}, 'message 2 unchanged');
+	SKIP: {
+		skip 'previous test failed', 1 if !scalar(@$x);
+		$x = $mic->message_string($x->[0]);
+		is($x, $ret->{2}->{RFC822}, 'message 2 unchanged');
+	}
 	$x = $mic->search(qw(text embedded));
 	is(scalar(@$x), 1, 'MSN SEARCH on TEXT works after rm');
 }

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-14 21:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 21:29 [PATCH] t/imapd.t: skip dependent test on failure Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).